Re: [PATCH] FNV-1 support for ext/hash
| From: | Pierre Joye | Date: | Wed, 24 Mar 2010 09:26:45 +0000 |
| Subject: | Re: [PATCH] FNV-1 support for ext/hash | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-47550@lists.php.net to get a copy of this message | ||
hi Sean,
On Wed, Mar 24, 2010 at 7:48 AM, sean finney <seanius@seanius.net> wrote:
> okay, so the hash module is generally broken for files > 2GB? didn't
> know that. i see update functions using both uint and size_t, but the
> function pointer signature uses uint so i doubt the hash results would
> be correct.
As far as I can tell that's not only for the hash module. Many areas
in php and its libraries rely on (u)int instead of size_t. It is or
was a common mistake. The problem is to change the signature now
without breaking ABI.
That's something we could fix in trunk.
Cheers,
--
Pierre
@pierrejoye | http://blog.thepimp.net | http://www.libgd.org