Re: [PATCH] FNV-1 support for ext/hash
| From: | sean finney | Date: | Wed, 24 Mar 2010 06:48:52 +0000 |
| Subject: | Re: [PATCH] FNV-1 support for ext/hash | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-47544@lists.php.net to get a copy of this message | ||
On Tue, Mar 23, 2010 at 11:18:09PM +0000, Michael Maclean wrote:
> >just to throw something out there, shouldn't the various inputLen
> >parameters be of type size_t instead of unsigned int?
>
> The function signature in php_hash.g says unsigned int, so that's
> what I used (though I note some of the other algorithms appear not
> to). We don't support files > 2^32 on 64-bit, so as I understand it,
> it's not going to cause issues right now, but if a large file
> support patch lands it's something that I might revisit.
okay, so the hash module is generally broken for files > 2GB? didn't
know that. i see update functions using both uint and size_t, but the
function pointer signature uses uint so i doubt the hash results would
be correct.
sean