Re: Adding path_len to all stream functions in trunk
| From: | Stas Malyshev | Date: | Tue, 16 Nov 2010 04:21:20 +0000 |
| Subject: | Re: Adding path_len to all stream functions in trunk | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-50224@lists.php.net to get a copy of this message | ||
Hi!
Ok, I went through all the 5.3 code. This should fix the null poisoning problems in 5.3 without breaking binary compatibility: http://progphp.com/nullpatch.txtLooking at this patch, I wonder if it wouldn't be cleaner to add new type (string without nulls) in parameter parsing and have it handled by parameter parsing in one place instead of doing it in dozens of different places? There might be some other places not covered but it would cover most functions - and it's easier to catch/fix those in extensions. -- Stanislav Malyshev, Software Architect SugarCRM: http://www.sugarcrm.com/ (408)454-6900 ext. 227