Re: Adding path_len to all stream functions in trunk

On 11/15/10 8:21 PM, Stas Malyshev wrote: > Hi! > >> Ok, I went through all the 5.3 code. This should fix the null poisoning >> problems in 5.3 without breaking binary compatibility: >> >> http://progphp.com/nullpatch.txt > > Looking at this patch, I wonder if it wouldn't be cleaner to add new > type (string without nulls) in parameter parsing and have it handled by > parameter parsing in one place instead of doing it in dozens of > different places? There might be some other places not covered but it > would cover most functions - and it's easier to catch/fix those in > extensions. Yeah, I thought about that too. Still not something we can do without breaking binary compatibility in the 5.3 branch though and I really would like to at least get all the core functions to guard themselves against null-poisoning there. -Rasmus