RE: [PHP-DEV] Adding path_len to all stream functions in trunk
| From: | Andi Gutmans | Date: | Tue, 16 Nov 2010 05:51:55 +0000 |
| Subject: | RE: [PHP-DEV] Adding path_len to all stream functions in trunk | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-50229@lists.php.net to get a copy of this message | ||
> -----Original Message-----
> From: Rasmus Lerdorf [mailto:rasmus@lerdorf.com]
> Sent: Monday, November 15, 2010 9:25 PM
> To: Andi Gutmans
> Cc: Stas Malyshev; internals
> Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk
>
> Well, it changes the signature of that function, so while we don't break
> backward binary compatibility, we break forward compatibility within the
> 5.3 branch. As in, if I change my extension to use this new NoNull string flag, it
> will no longer work on <5.3.3 whereas if I do the
> if(strlen(filename) != filename_len) check, this will still work in all
> 5.3 releases.
Yes that's correct although I am not sure of chances people would bump into this issue.
In any case, I think it's also fine to fix it the way you suggest in 5.3.x and then do it via
API in the next minor/major version.
Andi