RE: [PHP-DEV] Adding path_len to all stream functions in trunk
| From: | Andi Gutmans | Date: | Tue, 16 Nov 2010 05:16:16 +0000 |
| Subject: | RE: [PHP-DEV] Adding path_len to all stream functions in trunk | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-50227@lists.php.net to get a copy of this message | ||
> -----Original Message-----
> From: Stas Malyshev [mailto:smalyshev@sugarcrm.com]
> Sent: Monday, November 15, 2010 8:21 PM
> To: Rasmus Lerdorf
> Cc: internals
> Subject: Re: [PHP-DEV] Adding path_len to all stream functions in trunk
>
> Hi!
>
> > Ok, I went through all the 5.3 code. This should fix the null
> > poisoning problems in 5.3 without breaking binary compatibility:
> >
> > http://progphp.com/nullpatch.txt
>
> Looking at this patch, I wonder if it wouldn't be cleaner to add new type (string
> without nulls) in parameter parsing and have it handled by parameter parsing
> in one place instead of doing it in dozens of different places? There might be
> some other places not covered but it would cover most functions - and it's
> easier to catch/fix those in extensions.
That's a nice idea and it also wouldn't break binary compatibility.
Andi