Re: [PATCH] Friendly log messages for CLI server
| From: | Jérôme Loyet | Date: | Tue, 28 Jun 2011 23:30:07 +0000 |
| Subject: | Re: [PATCH] Friendly log messages for CLI server | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-53643@lists.php.net to get a copy of this message | ||
2011/6/29 Johannes Schlüter <johannes@schlueters.de>:
> On Tue, 2011-06-28 at 23:37 +0100, Arpad Ray wrote:
>> - Colours messages according to their response code (success=green,
>> client error=yellow, server error=red)
>
> I would prefer if this would be an ini option (if (cli_web_server.color
> && isatty) color = true) default can be on, but I've seen cases where
> such magic failed and created hard-to use results (due to control
> sequences in log files or such).
>
I agree with johannes. Color should be an option, all term does not
handle them correctly. Also, color control sequences are just killing
a log file.
++ Jerome