Re: [PATCH] Friendly log messages for CLI server
| From: | David Zülke | Date: | Thu, 30 Jun 2011 05:08:43 +0000 |
| Subject: | Re: [PATCH] Friendly log messages for CLI server | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-53694@lists.php.net to get a copy of this message | ||
On 29.06.2011, at 01:19, Johannes Schlüter wrote:
> On Tue, 2011-06-28 at 23:37 +0100, Arpad Ray wrote:
>> - Colours messages according to their response code (success=green,
>> client error=yellow, server error=red)
>
> I would prefer if this would be an ini option (if (cli_web_server.color
> && isatty) color = true) default can be on, but I've seen cases where
> such magic failed and created hard-to use results (due to control
> sequences in log files or such).
The code could detect if it's outputting to a TTY or not and only use color codes if the output
isn't redirected somewhere else.
David
Attachment: [application/pkcs7-signature] smime.p7s
Attachment: [application/pkcs7-signature] smime.p7s