Re: [PATCH] Friendly log messages for CLI server

On 06/30/2011 12:04 PM, Hannes Magnusson wrote:

On Thu, Jun 30, 2011 at 20:14, Lars Bo Rasmussen<lars@k0ngehuset.dk> wrote:

Instead of adding it as a php ini option, please consider adding this as a parameter to the php-cli executable as this might be something you would want to enable/disable quickly per instance. This would also make the coloring output more attractive to use instead of having to edit the ini file every time or have a seperate ini file just for the purpose to enable or disable coloring

Then you would be forced to always pass that option. If you want to enable it for one run you could do php -dcli.color=0 foo.php No need to edit the ini. -Hannes

If we have to have colouring at all, then I'd prefer a php.ini option to a command line option. The default should be coded Off, but can be set On in the php.ini-development file we ship. Preferably the parameter would be non-binary. This allows someone to extend it, including adding alternative colour schemes for the red-green impaired person: cli.webserver_log = COLOR_NONE cli.webserver_log = COLOR_REDGREEN ; uses red & green cli.webserver_log = COLOR_YELLOWBLUE ; uses yellow & blue cli.webserver_log = COLOR_REDGREEN | ERRORS_ONLY ; you get the idea Chris -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/