Re: [PATCH] Friendly log messages for CLI server
| From: | Christopher Jones | Date: | Tue, 28 Jun 2011 23:31:34 +0000 |
| Subject: | Re: [PATCH] Friendly log messages for CLI server | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-53644@lists.php.net to get a copy of this message | ||
On 06/28/2011 04:19 PM, Johannes Schlüter wrote:
On Tue, 2011-06-28 at 23:37 +0100, Arpad Ray wrote:I'm -1 on the color coding for a few reasons: (i) it can be done outside of PHP (ii) forcing a particular color coding is problematic for many users (iii) the escape codes are not portable. The other items in the patch have merit. If you're looking at the web server code, perhaps you can sort out the issues with subdirectories and include()? Moriyoshi has gone quiet on it. Chris -- Email: christopher.jones@oracle.com Tel: +1 650 506 8630 Blog: http://blogs.oracle.com/opal/- Colours messages according to their response code (success=green, client error=yellow, server error=red)I would prefer if this would be an ini option (if (cli_web_server.color && isatty) color = true) default can be on, but I've seen cases where such magic failed and created hard-to use results (due to control sequences in log files or such). johannes