Re: Property Accessors v1.2

On Thu, Oct 11, 2012 at 11:23 PM, Clint Priest <cpriest@zerocue.com> wrote: > Alright, here is the updated RFC as per discussions for the last few days: > > https://wiki.php.net/rfc/propertygetsetsyntax-as-implemented > > If you could read it over, make sure I have all of your concerns correctly addressed and we can > leave this open for the two week waiting period while I make the final code changes. > > -Clint > I'm not sure if that RFC is up to date; are ZEND_ACC_READONLY and ZEND_ACC_WRITEONLY still there? Are there still 79 test cases? I'd like to see wider coverage if you can think of more things to tests. Ideally every conditional statement has a test. I used to be very against this RFC but I admit the details have improved a lot with the ability to type hint and the removal of read and write only keywords. Levi Morrison