RE: [PHP-DEV] Re: Session: deprecating create_sid() method and add createSid()?

"If you would like, I can add similar change to 5.5." My question is how do clearances work in this group? Rajneesh N. Shetty Tel : (+61)468371858 ________________________________________ From: yohgaki@gmail.com [yohgaki@gmail.com] on behalf of Yasuo Ohgaki [yohgaki@ohgaki.net] Sent: Wednesday, 19 March 2014 11:08 AM To: Stas Malyshev Cc: internals@lists.php.net Subject: Re: [PHP-DEV] Re: Session: deprecating create_sid() method and add createSid()? Hi Stas, On Tue, Mar 18, 2014 at 4:44 PM, Stas Malyshev <smalyshev@sugarcrm.com>wrote: > > What is your opinion? > > My opinion it would be the best if we could support both and deprecate > create_sid in 5.6, but if it's hard to do cleanly, then leave it alone. > I've included createSid() definition in https://github.com/php/php-src/pull/628/ If create_sid() is defined, it's used. If both create_sid() and createSid() is defined, createSid() is used. SessionHandler does not use new SessionUpdateTimestampHandlerInterface, so user may choose what they would do about create_sid() and createSid(). Current session module's object handling is some what legacy, so such thing can be done. I think this is the best way. We can keep compatibility and have standard confirming createSid() name. Since it keeps compatibility with 5.5, we may leave 5.5 alone. If you would like, I can add similar change to 5.5. Regards, -- Yasuo Ohgaki yohgaki@ohgaki.net