Re: Re: BC break in 5.4.29 and 5.5.13

Hi Remi, On Fri, May 30, 2014 15:35, Remi Collet wrote: > Le 30/05/2014 13:45, Remi Collet a écrit : > >> Hi. >> >> >> Following http://news.php.net/php.internals/73957 >> >> >> This change breaks at least doctrine and phpunit. >> >> >> Source code: >> >> > > https://github.com/doctrine/doctrine2/blob/master/lib/Doctrine/ORM/Mappin > g /ClassMetadataInfo.php#L911 > > > Fixed in doctrine > > > ZymÚŠÅ\n'°Ê]η > https://github.com/doctrine/doctrine2/commit/93c276d059b40b0783ba9a24549a > 8 > b135e257693#diff-093aaad4da679d0374260757bf7bafca > >> > > https://github.com/sebastianbergmann/phpunit-mock-objects/blob/master/srcXºóg›Õ˜V’•Ò¼ > > / > Framework/MockObject/Generator.php#L274 > > > Fix in PHPUnit > > > > https://github.com/sebastianbergmann/phpunit-mock-objects/commit/1c68f133 > 8 > f1940deb8265428bb2a7cbc5bc074b5#diff-64dbbc1c21f9be2d92e2b715617ffe34 > > > https://github.com/sebastianbergmann/phpunit-mock-objects/commit/1c68f133 > 8 > f1940deb8265428bb2a7cbc5bc074b5#diff-64dbbc1c21f9be2d92e2b715617ffe34 > > thanks for the reproduce case. As discussed on the IRC, I'll be working on a solution to minimize the BC break in 5.4 and 5.5. IMHO 5.6 is fine with that "as is", as it's correct with the current specifications of the Serializable and fixes wide range crash vulnerability. Regards Anatol