Re: Re: BC break in 5.4.29 and 5.5.13
| From: | Remi Collet | Date: | Tue, 03 Jun 2014 13:28:28 +0000 |
| Subject: | Re: Re: BC break in 5.4.29 and 5.5.13 | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-74711@lists.php.net to get a copy of this message | ||
Le 03/06/2014 14:41, Anatol Belski a écrit :
> I've invented a patch fixing BC regarding this issue.
Tested. Work fine.
Thanks.
> It passes the
> userspace classes but blocks the internal classes. While it's a must for
> the stable 5.4 and 5.5,
Strongly agree.
> I still doubt we should put it into 5.6++. Even it
> can work with userspace classes, it's highly inconsistent. For example - a
> userclass implementing Serializable but throwing an exception in
> unserialize() will behave wrong when instantiated that way.
>
> Basically before I apply this fix - IMHO, it should go into 5.4 and 5.5
> only, 5.6 should have clean behaviour.
Agree.
Remi.
> From the userspace perspective -
> doctrine and phpunit have already fixed this using
> ReflectionClass::newInstanceWithoutConstructor(), so that is fine with the
> future. The fix should only go for legacy. So, what you say?
>
> Regards
>
> Anatol
>
>