Re: BC break in 5.4.29 and 5.5.13

On Tue, Jun 3, 2014 at 1:11 PM, Marco Pivetta <ocramius@gmail.com> wrote: > > It is going to be released, but yes, we actually have the expectation a > patch release for 5.4 and 5.5 with a rollback of this breakage. The original Doctrine PR that fixed this issue was https://github.com/doctrine/doctrine2/pull/1045, and Benjamin made some revisions in https://github.com/doctrine/doctrine2/commit/e577e7786796e9393df381f02221046dea6253a5 (note: there is a typo there, as he actually should be checking for 5.4.29 instead of 5.4.28). Based on the conversation above, it sounds like the revert will end up in 5.4.30 and 5.5.14, but we should expect the change for 5.6+. In that case, Benjamin's commit needs to (a) fix the 5.4.x typo and (b) add another condition to utilize Reflection for 5.6+. Has PHPUnit already incorporated a work-around for this? At a glance, I didn't see anything in the main repository or https://github.com/sebastianbergmann/phpunit-mock-objects. -- jeremy mikola