Re: Fixing (and making easier) Apache mod_proxy_fcgi with PHP-FPM

Julien, do you have any problem merging this PR to PHP-5.5(and merging upwards) so it can be released with 5.5.15 (and with 5.6.0RC2)? On Wed, Jun 25, 2014 at 12:15 AM, <dz@heroku.com> wrote: > The change is now in Apache 2.4.x ( > http://svn.apache.org/viewvc?view=revision&revision=1604378æl1òO£á¡š > ˆ„ÃÝ}) and they're > planning a release soon: > http://thread.gmane.org/gmane.comp.apache.devel/53822 > > Can someone please at least merge the pull request? Would be a shame IMO > if this didn't make it into 5.6.0. > > I'll gladly provide docs for this, too. > > David > > > On 20.06.2014, at 07:11, dz@heroku.com wrote: > > > Bump? > > > > We've been running > > http://github.com/php/php-src/pull/694 in production > at Heroku for a while now, with no issues. > > > > I really think this should be in 5.6, too. It'll make setting up PHP-FPM > so much less painful on Apache once their new release is out. > > > > And if someone could also please review and commit > https://bugs.php.net/bug.php?id=65641 (or find a better way; > I'll be glad > to help with anything like setting up Apache accordingly etc), then even > with current versions of Apache, PHP will finally work fine. Currently, > quite a few frameworks etc that use (or rewrite to) PATH_INFO are plainly > broken. > > > > Thanks, > > > > David > > > > > > On 17.06.2014, at 14:33, David Zuelke <dz@heroku.com> wrote: > > > >> On 13.06.2014, at 17:19, Pierre Joye <pierre.php@gmail.com> wrote: > >> > >>> On Fri, Jun 13, 2014 at 9:30 AM, Julien Pauli <jpauli@php.net> wrote: > >>>> On Thu, Jun 12, 2014 at 10:11 PM, Ferenc Kovacs <tyra3l@gmail.com> > wrote: > >>>>>> > >>>>>> Could we still squeeze this fix into 5.2.14? I know you just rolled > RC1 > >>>>>> (while I was fiddling with this stuff), but it would be so, so huge > to have > >>>>>> this in… or at least in 5.2.15. > >>>>>> > >>>>> > >>>>> just to prevent confusion, you meant 5.5.14 and 5.5.15 here. > >>>> > >>>> Obviously 5.5.X yes. > >>>> > >>>> I myself answered that I dont see any criticity to roll out an RC2 for > >>>> 5.5.14, just for this specific bug. > >>>> I think it can go to 5.5.15 or any version as far as the patch is > >>>> tested and merged up. > >>> > >>> Given the security issues fixes waiting to be released, I would not > >>> delay the releases any longer. > >> > >> So, who wants to merge the PR? :) > >> > >> And if someone could review and possibly apply any of the > https://bugs.php.net/bug.php?id=65641 attachments that'd > be great too, > although I suspect that it's possible to fix the problem way further up in > the code so that this stripping of stuff isn't even necessary at such a > "late" stage. > >> > >> With those two out of the way, PHP-FPM and Apache will be a lot, lot > easier to set up together. One bit of config, done. > >> > >> David > >> > >> P.S. would be great for 5.4 too I think, not just 5.5+! > >> > >> > > > > -- Ferenc Kovács @Tyr43l - http://tyrael.hu