Re: Fixing (and making easier) Apache mod_proxy_fcgi with PHP-FPM
| From: | David Zuelke | Date: | Thu, 26 Jun 2014 20:19:48 +0000 |
| Subject: | Re: Fixing (and making easier) Apache mod_proxy_fcgi with PHP-FPM | ||
| References: | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-75106@lists.php.net to get a copy of this message | ||
On 26.06.2014, at 12:23, Pierre Joye <pierre.php@gmail.com> wrote:
> On Jun 26, 2014 9:12 PM, "David Zuelke" <dz@heroku.com> wrote:
> >
>
> > That's what RCs are for, right? :)
>
> In an ideal world with ideal users yes.
>
> But we are not in that world :)
I know :)
For e.g. https://bugs.php.net/bug.php?id=65641 I
realize it's difficult to judge the potential impact; I've hit many different variations
of (F)CGI env vars, and it's one big mess where you pull on one end and it collapses on the
other.
The PR I'm suggesting however is not in the complicated fix_pathinfo/apache_was_here nightmare
section of the code and thus straightforward enough to evaluate.
Plus, it very obviously doesn't belong there in the first place. It fixes an issue that
can't even occur with FastCGI, and as a result (because the if() is very "generic"
and "aggressive" in how it tries to "detect" a certain situation), it breaks
other config combinations, such as the new SetHandler based Apache FastCGI proxying.
David