Re: Remove generated VM from git?
| From: | Andrea Faulds | Date: | Tue, 26 Aug 2014 23:21:58 +0000 |
| Subject: | Re: Remove generated VM from git? | ||
| References: | 1 2 3 4 5 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-76894@lists.php.net to get a copy of this message | ||
On 26 Aug 2014, at 22:17, Stas Malyshev <smalyshev@sugarcrm.com> wrote:
> That's not an advantage. Having extra file in git is no problem at all,
> we don't pay per byte, and somebody who can't handle regenerating the VM
> file should not be messing with the VM (for one, they would notice the
> problem immediately on running the test for the change locally, and if
> they don't test the changes locally we probably don't want these
> changes). And it's not like we change the VM every day.
Actually, I wouldn’t be so bothered by this if I didn’t have to manually regenerate the VM.
Would it be possible to make
make track Zend/zend_vm_def.h?
--
Andrea Faulds
http://ajf.me/