Re: Re: Remove generated lexers from git?
| From: | Stas Malyshev | Date: | Thu, 02 Oct 2014 19:04:09 +0000 |
| Subject: | Re: Re: Remove generated lexers from git? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-77746@lists.php.net to get a copy of this message | ||
Hi!
> Case in point: The current zend_language_scanner.c has been generated by
> Andrea, who uses a different re2c version from everybody else (0.13.6
> instead of 0.13.5). This means that if I do some tiny change to
> zend_language_scanner.l I immediately get a 3000 line diff. So we just end
> up changing this file back and forth depending on the algorithm used by
> different versions.
So, from time to time we'd get a big diff. But what's a big problem with
that? It doesn't seem to hurt anything. And language scanner is not
changed every day. I don't see any benefit in such change, just making
building PHP harder.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/