Re: Re: Remove generated lexers from git?

Hi, On Thu, Oct 2, 2014 at 10:12 PM, Stas Malyshev <smalyshev@sugarcrm.com> wrote: > Hi! > > > Sorry to intrude, but why would building be harder? Tbh I don't see the > > Because there are more dependencies and tools needed to build the > parsers. You'd have to have recent re2c, for example. Which does not > come by default with many systems. I see no reason to add this hurdle > with no benefit for anybody. > It's already necessary; PHP won't pass the configure step without re2c. > > > Also, there may be a small number of "big diffs", but one is enough to > > introduce a bug. Generating the file every time ensures there is no > > hidden bug. > > Which bug? They are generated parsers from the same source, what kind of > bug you're talking about? > Slipping in a malicious code in such a diff could easily go unnoticed, for instance. Or simply going to the file to see the generated code, leave a letter by mistake because the cat jumps on the keyboard, and there you go. I just mean that such big diffs are simply unreviewable; you have to trust that it was generated and not touched after. Why this unnecessary trust to give, when we can simply not have the file? > > -- > Stanislav Malyshev, Software Architect > SugarCRM: http://www.sugarcrm.com/ > -- Florian Margaine