Re: Remove generated lexers from git?
| From: | Maciej Sobaczewski | Date: | Thu, 02 Oct 2014 04:48:07 +0000 |
| Subject: | Re: Remove generated lexers from git? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-77742@lists.php.net to get a copy of this message | ||
Hello,
sorry if I'm totally wrong - I have no experience in this area, but if someone is strongly against removing those files for any reason (not that I would) then we might consider passing -i flag while generating C files with re2c.
As far as I can see most of the changes listed on every diff touching this file are different line numbers in comments. This option should disable them if only re2c documentation[1] is right.
Regards,
Maciej.
[1]: http://re2c.org/manual.html
I'd like to bring this up again. It seems the thread got side-tracked with unrelated discussion (about vm_execute.h) and I didn't get any answers to the original question. Case in point: The current zend_language_scanner.c has been generated by Andrea, who uses a different re2c version from everybody else (0.13.6 instead of 0.13.5). This means that if I do some tiny change to zend_language_scanner.l I immediately get a 3000 line diff. So we just end up changing this file back and forth depending on the algorithm used by different versions. Nikita