Re: [RFC] Default constructors
| From: | Stanislav Malyshev | Date: | Thu, 20 Nov 2014 18:43:34 +0000 |
| Subject: | Re: [RFC] Default constructors | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79047@lists.php.net to get a copy of this message | ||
Hi!
> I think the idea is good.
> I'm not sure about implementation.
> Additional check for ZEND_NULL_FUNCTION in DO_FCALL may be expensive.
> I think it must be better to use special predefined function (see
> "zend_pass_function" usage in zend_vm_def.h).
I've moved the condition after internal & user function, so the slowdown
would almost never happen and will be very minimal. But if you prefer, I
can do the other one, I actually implemented it first with the function
but then removed it since I thought ability to skip a function call may
be faster and also prove useful in other cases. I'll try to do another
version with zend_pass_function and see if I see any difference.
--
Stas Malyshev
smalyshev@gmail.com