Re: [RFC] Default constructors
| From: | Stanislav Malyshev | Date: | Fri, 21 Nov 2014 03:59:47 +0000 |
| Subject: | Re: [RFC] Default constructors | ||
| References: | 1 2 3 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-79064@lists.php.net to get a copy of this message | ||
Hi!
>> Additional check for ZEND_NULL_FUNCTION in DO_FCALL may be expensive.
>> I think it must be better to use special predefined function (see
>> "zend_pass_function" usage in zend_vm_def.h).
I've made a different implementation here:
https://github.com/smalyshev/php-src/compare/php:master...smalyshev:default_ctor_func?expand=1
which uses zend_pass_function but I had to make it static since
otherwise it's increase refcount for object and it doesn't seem like it
decrements back. So I'm not sure if it's right, what do you think?
--
Stas Malyshev
smalyshev@gmail.com