Re: new json, push generated file?
| From: | Stanislav Malyshev | Date: | Mon, 09 Feb 2015 03:45:19 +0000 |
| Subject: | Re: new json, push generated file? | ||
| References: | 1 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-82216@lists.php.net to get a copy of this message | ||
Hi!
> Should we push json_parser.tab.c? Which is generated (re2c), just like
> what is done in date or other?
I think we should, otherwise building from release package without re2c
would be impossible, and I think before it was possible. In any case, we
should be consistent - if we commit generated files (which we do), we
should do it everywhere.
--
Stas Malyshev
smalyshev@gmail.com