Re: new json, push generated file?
| From: | Anatol Belski | Date: | Mon, 09 Feb 2015 09:18:15 +0000 |
| Subject: | Re: new json, push generated file? | ||
| References: | 1 2 3 4 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-82249@lists.php.net to get a copy of this message | ||
Hi,
On Mon, February 9, 2015 07:33, Xinchen Hui wrote:
> Hey:
>
>
>
>
> On Mon, Feb 9, 2015 at 1:44 PM, Pierre Joye <pierre.php@gmail.com> wrote:
>
>> On Mon, Feb 9, 2015 at 11:10 AM, Xinchen Hui <laruence@php.net> wrote:
>>
>>> Hey:
>>>
>>>
>>> On Mon, Feb 9, 2015 at 10:40 AM, Pierre Joye <pierre.php@gmail.com>
>>> wrote:
>>>
>>>> hi,
>>>>
>>>> Should we push json_parser.tab.c? Which is generated (re2c), just
>>>> like what is done in date or other?
>>>>
>>> I think we should, and also use a better name...(.tab.c?)
>>>
>>
>> that too :)
> simply, json_parser.c is good
>
> something like: https://gist.github.com/laruence/f33903266cec737088aaD3E_Ò
> ÆΔE%ûKÔv
>
I'd be for applying this as well. Also, just added the generation calls to
config.w32, but actulaly a checked in file were much simpler to handle.
Regards
Anatol