Re: Re: new json, push generated file?
| From: | Pierre Joye | Date: | Mon, 09 Feb 2015 07:55:58 +0000 |
| Subject: | Re: Re: new json, push generated file? | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-82232@lists.php.net to get a copy of this message | ||
On Mon, Feb 9, 2015 at 2:48 PM, Jan Ehrhardt <phpdev@ehrhardt.nl> wrote:
> Pierre Joye in php.internals (Mon, 9 Feb 2015 09:40:21 +0700):
>>Should we push json_parser.tab.c? Which is generated (re2c), just like
>>what is done in date or other?
>
> Yes, you should. I ran into this problem when I tried to compile PHP7
> from git head. The Windows builds are currently broken:
>
> http://windows.php.net/downloads/snaps/master/r0698901/logs/make-nts-windows-vc11-x86-r0698901.html
Yes, that's where I notice it was not present when I was working on
fixing the build in the 1st place (adding re2c call on win)
--
Pierre
@pierrejoye | http://www.libgd.org