Re: Re: [RFC] Exceptions in the engine

Hey: On Tue, Feb 24, 2015 at 2:27 AM, Marc Bennewitz <dev@mabe.berlin> wrote: > Hi Dimitry, > > Am 19.02.2015 um 16:13 schrieb Dmitry Stogov: >> >> Hi Nikita, >> >> I refactored your implementation: >> https://github.com/php/php-src/pull/1095 >> >> I introduced a class hierarchy to minimize effect on existing code. >> cacth (Exception $e) won't catch new types of exceptions. >> >> BaseException (abstarct) >> +- EngineException >> +- ParaseException >> +- Exception >> +-ErrorException >> +- all other exceptions > > I really like this RFC and Exception hierarchy but one very small note: > The name of BaseException is a bit to misunderstanding to me as it clashes > with the old base exception named Exception, which is by the way very often > used as alias (use Exception as BaseExcepton). > I know this isn't a technical issue but it reduces readability a code. > > What are your thoughts about the following names ?: > > RootException > AbstractExcepton +1 for AbstarctException. thanks > >> <snip> > > > Marc > > > -- > PHP Internals - PHP Runtime Development Mailing List > To unsubscribe, visit: http://www.php.net/unsub.php -- Xinchen Hui @Laruence http://www.laruence.com/