RE: [PHP-DEV] Re: ext/curl update
| From: | Anatol Belski | Date: | Wed, 27 Apr 2016 06:46:42 +0000 |
| Subject: | RE: [PHP-DEV] Re: ext/curl update | ||
| References: | 1 2 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-92832@lists.php.net to get a copy of this message | ||
Hi,
> -----Original Message-----
> From: me@daveyshafik.com [mailto:me@daveyshafik.com] On Behalf Of Davey
> Shafik
> Sent: Sunday, April 24, 2016 2:25 AM
> To: Pierrick Charron <pierrick@adoy.net>
> Cc: PHP internals <internals@lists.php.net>; pajoye@php.net
> Subject: [PHP-DEV] Re: ext/curl update
>
> Hi Pierrick,
>
> This should be in master for 7.1, alongside my RFC'ed patch for server push
> support.
>
> You emailed me directly about the aforementioned patch so I'll just respond
> here as it's relevant:
>
> The patch should hit in 7.1 but it has been requested that tests be added — and
> we can't add tests with a server push supporting HTTP/2 server against which to
> push.
>
As from the patch, many constants have nothing to do with HTTP/2 implementation and add just
name/value without any further logic. If there were a reduced patch with only such cases, it would
be acceptable for 7.0 as well and there were probably no collisions expected. What do you think?
Regards
Anatol