Re: Re: ext/curl update
| From: | Nikita Popov | Date: | Thu, 05 May 2016 13:32:17 +0000 |
| Subject: | Re: Re: ext/curl update | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-93088@lists.php.net to get a copy of this message | ||
On Thu, Apr 28, 2016 at 11:30 PM, Davey Shafik <davey@php.net> wrote:
> I seem to have created some confusion here:
>
> The reason _my_ patch for Server Push isn't merged is tests for it were
> requested and are blocking it. I'm not saying tests for these constants
> should be added.
>
For the record, I'm fine with landing your server push patch based on
review and manual tests only. It is not an ideal situation, but I don't
think we should block this kind of trivial change on the implementation of
full-blown HTTP 2.0 support in the built-in server. The latter is a much
bigger project, I'm sure it's going to be somewhat controversial (pulls in
new dependencies) and I don't see how this can land on the 7.1 timeline
(unless someone is actively working on a patch already?)
Nikita