Re: Re: ext/curl update

Yep I'll check if I can add some test that could be easy to implement using curl_easy_getinfo or using the php local server. Otherwise not sure we could easily compile PHP with all those libcurl versions... On 27 April 2016 at 11:37, Anatol Belski <anatol.php@belski.net> wrote: > Hi, > > > -----Original Message----- > > From: pierrick@webstart.fr [mailto:pierrick@webstart.fr] On Behalf Of > Pierrick > > Charron > > Sent: Wednesday, April 27, 2016 2:20 PM > > To: Anatol Belski <anatol.php@belski.net> > > Cc: Davey Shafik <davey@php.net>; PHP internals <internals@lists.php.net > >; > > pajoye@php.net > > Subject: Re: [PHP-DEV] Re: ext/curl update > > > > I agree, but I don't really now how I could test those things since they > almost all > > of the time only affect how libcurl will handle the request/cache and we > have no > > way to retrieve options like curl_easy_getopt or something similar. > > > > On 27 April 2016 at 02:46, Anatol Belski <anatol.php@belski.net > > <mailto:anatol.php@belski.net> > wrote: > > > > > > Hi, > > > > > -----Original Message----- > > > From: me@daveyshafik.com > > > <mailto:me@daveyshafik.com> > > [mailto:me@daveyshafik.com > > <mailto:me@daveyshafik.com> ] On Behalf Of > > Davey > > > Shafik > > > Sent: Sunday, April 24, 2016 2:25 AM > > > To: Pierrick Charron <pierrick@adoy.net <mailto: > pierrick@adoy.net> > > > > Cc: PHP internals <internals@lists.php.net > > <mailto:internals@lists.php.net> >; > > pajoye@php.net <mailto: > pajoye@php.net> > > > Subject: [PHP-DEV] Re: ext/curl update > > > > > > Hi Pierrick, > > > > > > This should be in master for 7.1, alongside my RFC'ed patch for > server > > push > > > support. > > > > > > You emailed me directly about the aforementioned patch so I'll > just > > respond > > > here as it's relevant: > > > > > > The patch should hit in 7.1 but it has been requested that tests > be > > added — and > > > we can't add tests with a server push supporting HTTP/2 server > against > > which to > > > push. > > > > > As from the patch, many constants have nothing to do with HTTP/2 > > implementation and add just name/value without any further logic. If > there were > > a reduced patch with only such cases, it would be acceptable for 7.0 as > well and > > there were probably no collisions expected. What do you think? > > > So far I understood tests are exactly about HTTP2. Not sure how you would > tests all the constants present in libcurl. Would need to rebuild with a > dozen libcurl versions, but the documentation and compile time version > check are already reliable things. > > Thanks > > anatol > > >