Re: The death of `#ifndef FAST_ZPP`?

Hi Christoph, Christoph M. Becker wrote:

On 04.05.2016 at 18:11, Andrea Faulds wrote: It seems to me that the FAST_ZPP macro is not (only) to disable an experimental feature, but rather to be able to reduce the size of the built binaries. I've just checked a ./configure --disable-all:

   with FAST_ZPP:    16,651,912

without FAST_ZPP: 16,276,152 That's a difference of 375,760 bytes, but only 2% increase.

This is a fair point. Functions using Fast ZPP have larger code size, because of aggressive inlining. If every function used it, I suppose it might bloat the size of the PHP binary somewhat.

Furthermore, I have no reason to believe that the option to turn off FAST_ZPP is actually used in practice, though feel free to prove me wrong!

Perhaps that is so, because FAST_ZPP can't be turned of via ./configure.

That's true, but I don't know if there was any reason to add such an option. In any case, thanks to some uncaught bugs in dead code, no stable release of PHP 7 has been able to compile with FAST_ZPP disabled anyway, which means I can be certain nobody is using it. Thanks for your input. -- Andrea Faulds https://ajf.me/