Re: Follow up to "The death of `#ifndef FAST_ZPP`?"

Hi Andrea, On Sep 12, 2016 4:57 AM, "Andrea Faulds" <ajf@ajf.me> wrote: > > Hi everyone, > > Andrea Faulds wrote: >> >> I finally wrote a patch to get rid of it: >> >> https://github.com/php/php-src/pull/2118 >> >> Perhaps this will go somewhere. :) > > > This has now been merged into PHP-7.0 and up: > > https://github.com/php/php-src/commit/d690014bf35507ccb7a1150a27504d2f87848842 > > Additionally, extra zpp fallback code only found in master has been removed here: > > https://github.com/php/php-src/commit/3cc90901010f016923e9ca6a4ae15ba08bc18169 > > Now there is no fallback zpp code around, and Fast ZPP is always enabled. > > The FAST_ZPP macro itself remains for compatibility with outside extensions, but it doesn't do anything within php-src. > > If you're writing a function that needs parameter parsing and which targets only PHP 7.0+, you now don't need to (and shouldn't) include zpp fallback code if you're using Fast ZPP. > > Thanks! Thanks you :) Please add this note to UPGRADING.INTERNALS as well : Cheers Pierre