Re: Follow up to "The death of `#ifndef FAST_ZPP`?"
| From: | Pierre Joye | Date: | Thu, 15 Sep 2016 04:06:19 +0000 |
| Subject: | Re: Follow up to "The death of `#ifndef FAST_ZPP`?" | ||
| References: | 1 2 3 4 5 6 | Groups: | php.internals |
| Request: | Send a blank email to internals+get-96005@lists.php.net to get a copy of this message | ||
On Sep 15, 2016 7:10 AM, "Andrea Faulds" <ajf@ajf.me> wrote:
>
> Hi Pierre,
>
>
> Pierre Joye wrote:
>>
>>
>> Thanks you :)
>>
>> Please add this note to UPGRADING.INTERNALS as well :
>
>
> Well, I was wondering about that, but I don't really know where it should
be noted.
>
> It's not a user-facing change, in fact nobody was disabling FAST_ZPP
anyway, so it couldn't be one. Therefore, it shouldn't be noted in NEWS.
>
> And UPGRADING.INTERNALS is an upgrading guide used between major or minor
releases. This is a patch change that affects not only master, but 7.1 and
7.0. So it isn't suitable for that, either.
>
> Plus, UPGRADING.INTERNALS has no existing mention of Fast ZPP.
>
> So, it doesn't seem to go anywhere, unfortunately. :/
>
It does fit there. It was something we forgot to mention in 7.0 so let fix
that now.
Cheers
Pierre