Re: SPPLUS

Almost of that has been fixed in CVS. For the rest, I'm working on it. M.CHAILLAN Nicolas nicos@php.net www.WorldAKT.com Hébergement de sites internets. ----- Original Message ----- From: "Derick Rethans" <derick@php.net> To: <nicos@php.net> Cc: "Pierre-Alain Joye" <paj@pearfr.org>; <pear-dev@lists.php.net> Sent: Friday, November 08, 2002 3:31 PM Subject: Re: [PEAR-DEV] SPPLUS > On Thu, 7 Nov 2002 nicos@php.net wrote: > > > Okay, here is the code: > > > > http://nicos.worldakt.com/spplus/ > > > > files: > > -config.m4 > > -CREDITS > > -php_spplus.c > > -php_spplus.h > > -spplus.php > > -tests/001.phpt > > > > > > Just tell me if there are any bugs, I will patch. > > In the current state this code should definitely not be approved. > > 1. misuse of memory management (Strdupping return values and not freeing > returned char*'s from the lib) > 2. usage of tons of convert_to_String while using zend_parse_parameters > would make the code: > a. more readable > b. much shorter > 3. There is no test file per function, just one for all functions. > 4. Comments as generated by ext_skel are not removed. > 5. Messed up prototypes > 6. Not complying with general coding standards > 7. Unused, but defined MINIT and MSHUTDOWN sections > 8. Missing licence header, including checks if the code is actually > enabled > 9. Function names in french > > -1 on this. > > Derick > > -- > > -------------------------------------------------------------------------- - > Derick Rethans > http://derickrethans.nl/ > JDI Media Solutions > --------------[ if you hold a unix shell to your ear, do you hear the c? ]- > >