#25209 [NEW]: pear build fails unexpectedly

From: eru@php.net Operating system: Linux PHP version: Irrelevant PHP Bug Type: PEAR related Bug description: pear build fails unexpectedly Description: ------------ pear build/install will fail with almost every PECL out there, because of two misplaced !s. Diff: --- Builder.php.orig Fri Aug 22 10:57:54 2003 +++ Builder.php Fri Aug 22 16:21:47 2003 @@ -201,8 +201,7 @@ $err = $this->_runCommand("phpize", array(&$this, 'phpizeCallback')); if (PEAR::isError($err)) { return $err; - } - if (!$err) { + } elseif ($err) { return $this->raiseError("`phpize' failed"); } @@ -255,8 +254,7 @@ if (PEAR::isError($err)) { chdir($old_cwd); return $err; - } - if (!$err) { + } elseif ($err) { chdir($old_cwd); return $this->raiseError("`$cmd' failed"); } So either we have a PHP_Error, or some error-code is in $err, or everything is fine and the show can go on... With this patch it works again... -- Edit bug report at http://bugs.php.net/?id=25209&edit=1 -- Try a CVS snapshot (php4): http://bugs.php.net/fix.php?id=25209&r=trysnapshot4 Try a CVS snapshot (php5): http://bugs.php.net/fix.php?id=25209&r=trysnapshot5 Fixed in CVS: http://bugs.php.net/fix.php?id=25209&r=fixedcvs Fixed in release: http://bugs.php.net/fix.php?id=25209&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=25209&r=needtrace Try newer version: http://bugs.php.net/fix.php?id=25209&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=25209&r=support Expected behavior: http://bugs.php.net/fix.php?id=25209&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=25209&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=25209&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=25209&r=globals PHP 3 support discontinued: http://bugs.php.net/fix.php?id=25209&r=php3 Daylight Savings: http://bugs.php.net/fix.php?id=25209&r=dst IIS Stability: http://bugs.php.net/fix.php?id=25209&r=isapi Install GNU Sed: http://bugs.php.net/fix.php?id=25209&r=gnused