#25209 [Fbk->Opn]: pear build fails unexpectedly

ID: 25209 User updated by: eru@php.net Reported By: eru@php.net -Status: Feedback +Status: Open Bug Type: PEAR related -Operating System: Linux +Operating System: Linux RH 8.0 -PHP Version: Irrelevant +PHP Version: 4.3.3RC5-dev, PEAR 1.2.1 Assigned To: cellog New Comment: I just ran pear install xdebug, no problems there... _runCommand returns ($exitcode == 0) as default A failed install ends in running: phpize autoheader: `config.h.in' is created Configuring for: PHP Api Version: 20020918 Zend Module Api No: 20020429 Zend Extension Api No: 20021010 `phpize' failed Previous Comments: ------------------------------------------------------------------------ [2003-08-25 13:13:29] cellog@php.net This patch actually broke pear install cybercash and pear install xdebug, I'm running Redhat Linux 9 with PHP 4.3.2 and PEAR 1.2.1. I had to keep the !$err Could you provide sample output for a failed install, and what OS you're running? Greg ------------------------------------------------------------------------ [2003-08-22 09:25:51] eru@php.net Description: ------------ pear build/install will fail with almost every PECL out there, because of two misplaced !s. Diff: --- Builder.php.orig Fri Aug 22 10:57:54 2003 +++ Builder.php Fri Aug 22 16:21:47 2003 @@ -201,8 +201,7 @@ $err = $this->_runCommand("phpize", array(&$this, 'phpizeCallback')); if (PEAR::isError($err)) { return $err; - } - if (!$err) { + } elseif ($err) { return $this->raiseError("`phpize' failed"); } @@ -255,8 +254,7 @@ if (PEAR::isError($err)) { chdir($old_cwd); return $err; - } - if (!$err) { + } elseif ($err) { chdir($old_cwd); return $this->raiseError("`$cmd' failed"); } So either we have a PHP_Error, or some error-code is in $err, or everything is fine and the show can go on... With this patch it works again... ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=25209&edit=1