#25209 [Opn->Fbk]: pear build fails unexpectedly
| From: | cellog@php.net | Date: | Sun, 07 Sep 2003 21:31:41 +0000 |
| Subject: | #25209 [Opn->Fbk]: pear build fails unexpectedly | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-21152@lists.php.net to get a copy of this message | ||
ID: 25209
Updated by: cellog@php.net
Reported By: eru@php.net
-Status: Open
+Status: Feedback
Bug Type: PEAR related
-Operating System: Linux RH 8.0
+Operating System: linux
-PHP Version: 4.3.3RC5-dev, PEAR 1.2.1
+PHP Version: 4.3.3RC5-dev
Assigned To: cellog
New Comment:
Hi there,
I just tested pear install sqlite, with complete success - I wonder if
the problem is in your phpize? Perhaps you could try the build with
phpize straight from CVS? I saw a few commits in recent weeks that
fixed a broken phpize.
Sorry I can't be more helpful - the bug just doesn't appear to exist on
my setup. If there are any devs running RH 8.0, it would be good to
step in and test out this problem.
Regards,
Greg
Previous Comments:
------------------------------------------------------------------------
[2003-08-27 15:31:43] eru@php.net
jeez, sorry, that you have to pull all the information from me... it
was sqlite
------------------------------------------------------------------------
[2003-08-27 13:34:00] cellog@php.net
$ pear install ????
Could you please replace ???? with the name of a package that gives the
failed install :)
Thanks,
Greg
------------------------------------------------------------------------
[2003-08-27 05:00:52] eru@php.net
I just ran pear install xdebug, no problems there...
_runCommand returns ($exitcode == 0) as default
A failed install ends in
running: phpize
autoheader: `config.h.in' is created
Configuring for:
PHP Api Version: 20020918
Zend Module Api No: 20020429
Zend Extension Api No: 20021010
`phpize' failed
------------------------------------------------------------------------
[2003-08-25 13:13:29] cellog@php.net
This patch actually broke pear install cybercash and pear install
xdebug, I'm running Redhat Linux 9 with PHP 4.3.2 and PEAR 1.2.1. I
had to keep the !$err
Could you provide sample output for a failed install, and what OS
you're running?
Greg
------------------------------------------------------------------------
[2003-08-22 09:25:51] eru@php.net
Description:
------------
pear build/install will fail with almost every PECL out there, because
of two misplaced !s.
Diff:
--- Builder.php.orig Fri Aug 22 10:57:54 2003
+++ Builder.php Fri Aug 22 16:21:47 2003
@@ -201,8 +201,7 @@
$err = $this->_runCommand("phpize", array(&$this,
'phpizeCallback'));
if (PEAR::isError($err)) {
return $err;
- }
- if (!$err) {
+ } elseif ($err) {
return $this->raiseError("`phpize' failed");
}
@@ -255,8 +254,7 @@
if (PEAR::isError($err)) {
chdir($old_cwd);
return $err;
- }
- if (!$err) {
+ } elseif ($err) {
chdir($old_cwd);
return $this->raiseError("`$cmd' failed");
}
So either we have a PHP_Error, or some error-code is in $err, or
everything is fine and the show can go on...
With this patch it works again...
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=25209&edit=1