#25209 [Asn->Fbk]: pear build fails unexpectedly
| From: | cellog@php.net | Date: | Mon, 25 Aug 2003 18:13:29 +0000 |
| Subject: | #25209 [Asn->Fbk]: pear build fails unexpectedly | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-20498@lists.php.net to get a copy of this message | ||
ID: 25209
Updated by: cellog@php.net
Reported By: eru@php.net
-Status: Assigned
+Status: Feedback
Bug Type: PEAR related
Operating System: Linux
PHP Version: Irrelevant
Assigned To: cellog
New Comment:
This patch actually broke pear install cybercash and pear install
xdebug, I'm running Redhat Linux 9 with PHP 4.3.2 and PEAR 1.2.1. I
had to keep the !$err
Could you provide sample output for a failed install, and what OS
you're running?
Greg
Previous Comments:
------------------------------------------------------------------------
[2003-08-22 09:25:51] eru@php.net
Description:
------------
pear build/install will fail with almost every PECL out there, because
of two misplaced !s.
Diff:
--- Builder.php.orig Fri Aug 22 10:57:54 2003
+++ Builder.php Fri Aug 22 16:21:47 2003
@@ -201,8 +201,7 @@
$err = $this->_runCommand("phpize", array(&$this,
'phpizeCallback'));
if (PEAR::isError($err)) {
return $err;
- }
- if (!$err) {
+ } elseif ($err) {
return $this->raiseError("`phpize' failed");
}
@@ -255,8 +254,7 @@
if (PEAR::isError($err)) {
chdir($old_cwd);
return $err;
- }
- if (!$err) {
+ } elseif ($err) {
chdir($old_cwd);
return $this->raiseError("`$cmd' failed");
}
So either we have a PHP_Error, or some error-code is in $err, or
everything is fine and the show can go on...
With this patch it works again...
------------------------------------------------------------------------
--
Edit this bug report at http://bugs.php.net/?id=25209&edit=1