Re: AW: [PEAR-DEV] XML_Parser/XML_Tree bugs/problems, post them here please

On Monday, September 8, 2003 13:33, Stephan Schmidt wrote: > Hi, >> I'm willing to upload new XML_Parser and XML_Tree versions containing >> all the fixes people was posting in the last time (plus other patches >> I currently have). As I'm not able to >> dig into the mailing list, please put under this thread those bug >> reports, patches, comments, you may have with these two classes (don't >> forget to check against the latest CVS version of the files). > I've been working on XML_Parser, and here's my patch. > I did the following stuff: > - added defines for error codes > - added a free() method > - added an autofree property > - removed some notices (undefined variables/properties) > - added namespace support in the constructor (and with a enableNamespaces() > method) > - added handlers for na declarations > - removed the fopen() and ereg() from setInput (in fact the diff did this > and I did not include this in my version) > - added a reset() method to parse more than one file > - moved allocation of parser resource to the reset() method, so it's not > allocated when XML_Parser is instantiated. > Hope the changes will make it into the next release. I'm willing to put more > effort in this class (I'm still working on some XML based packages). Hi Stephan, I was reviewing your patch and found some issues I'd like to comment you: - The diff can't be applied to the current XML_Parser CVS version - setInput() now does not accept a file name? - The reset() method basically let you reuse the same object for parsing more than one document? Thanks, -- Tomas V.V.Cox mailto:cox@idecnet.com