Re: AW: AW: [PEAR-DEV] XML_Parser/XML_Tree bugs/problems, post them here please

On Wednesday, September 10, 2003 10:19, Stephan Schmidt wrote: > Hi, >> - The diff can't be applied to the current XML_Parser CVS version > That's strange, I tried it with the current CVS version... Maybe someone > already applied a different patch to the CVS... > Should I send you the complete file or a new patch? If you are so kind please send me a new patch, would thank you a lot the extra effort. A test for the new features would be cool too, but nm if you don't have much time. >> - setInput() now does not accept a file name? > That's not something I did. Marshall Roch implemented this. I already had a > discussion with him on pear-dev as I think it's not a good idea[tm] to let a > script guess if I'm supplying XML or a file. I'm not able to find in the > the archives :-( Umm, let's add a new setInputString() method (there is already a setInputFile()), ok? So you'll have all the options avaible and we won't break BC. >> - The reset() method basically let you reuse the same object for >> parsing more than one document? > Yes, that's correct. Currently that's not possible. Ok, that's fine. But maybe the reset() should be inside the setInput*() methods? A user case: $xml = new XML_Parser; $xml->setInputFile('foo.xml'); $xml->parse(); $xml->setInputFile('bar.xml'); $xml->parse(); One more thing, would be nice if the free() method could close the file resource if any. -- Tomas V.V.Cox mailto:cox@idecnet.com