Re: AW: AW: AW: [PEAR-DEV] XML_Parser/XML_Tree bugs/problems, post them here please
| From: | Marshall Roch | Date: | Wed, 10 Sep 2003 10:47:30 +0000 |
| Subject: | Re: AW: AW: AW: [PEAR-DEV] XML_Parser/XML_Tree bugs/problems, post them here please | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-21338@lists.php.net to get a copy of this message | ||
Stephan Schmidt wrote:
The reason for my change was to keep developers from having to guess in their own packages, in which case they could miss something (like I did with the original regex) that would cause problems. I can't come up with *any* examples where a string might get mistaken for a URL, even if the string is a cached PHP error or something. Arguing between ourselves isn't getting anywhere fast. I'd like to hear what others have to say; it looks like Tomas and Martin already more-or-less approve. -- Marshall Roch http://pear.php.net/user/mrochUmm, let's add a new setInputString() method (there is already a setInputFile()), ok? So you'll have all the options avaible and we won't break BC.That's ok for me, but I think it would be OK if setInput would accept a string which will always be treated like an XML string. It's easy to decide whether a resource or string was given but hard to decide whether is a string or a filename...