Re: Mod 10 for Payment package?

On 17 Sep 2003 at 12:23, Tomas V.V.Cox wrote: > On Wednesday, September 17, 2003 10:49, Pierre-Alain Joye wrote: > > > On Wed, 17 Sep 2003 10:41:29 +0200 > > "Stefan Neufeind" <stefan@neufeind.net> wrote: > > >> For sure your contributions are always welcome. But maybe Joe could > >> have a look at it, compare it with his ideas and if he has further > >> contributions / checks / ... could streamline all the up-coming > >> ideas? > > > Yeah go ahead to commit changes according to our discussion. Once > > you are ready mail me, then I'll launch a new alpha release. > > > It will be easier for you to get feedbacks. > > > One important point about Validate is it will always return > > true/false. It is the main idea behind it. However subclasses may > > provide more informations about what is wrong in a given data. > > Tomas, agreed? > > If there will be functions returning error codes, I guess that would > be better to normalize this situation to all functions. > > If error codes starts from -1 to -n, the look will be: > > Simple check: > > if (Validate::foo('bar') < 0) { > die("invalid 'bar'"); > } Hmm, wouldn't using true / false for a more easy if-statement be better? > Complex check: > > $error = Validate::foo('bar'); > if ($error == VALIDATE_FOO_TOO_SHORT) { > die("'$bar' was too short"); > // or even provide error messages > die(Validate::getMessage(VALIDATE_FOO_TOO_SHORT)); > // other idea > die(Validate::getLastErrorMessage()); > } > > I'd use VALIDATE_<FUNCTION>_MSG for the convention. The objective of > the class was simplicity of checking, but I agree that many people > need or want to have precise info about the error. > > It's up to you Pierre, I'm just giving ideas :) Tomas, please have a look at: http://cvs.php.net/co.php/pear/Validate/Validate/Finance/IBAN.php?logi n=2&r=1.3 There are already functions for retrieving errorMessage and errorCode. If you use validate::iban() you just get the usual true / false - since this is enough in most cases. And this is a common interface for all the basic Validate functions. But if you write an app that bothers about details you can easily use an object of Validate_Finance_IBAN and if it returns "false" you can query errorCode (if you want to translate it yourself to something useful) or errorMessage (if you want a complete string describing the error). If you find the time, please take a short look at IBAN.php in CVS and comment on the errorHandling-implementation. In my eyes this is a convenient way that allows you: a) to do simplistic checks for true / false according to the common results of the other Validate-check-functions b) to do "advanced" checks and error-handling if you feel like it. Stefan