Re: ATTN: Validate Package Maintainer
| From: | Pierre-Alain Joye | Date: | Sun, 14 Dec 2003 10:50:33 +0000 |
| Subject: | Re: ATTN: Validate Package Maintainer | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-24404@lists.php.net to get a copy of this message | ||
On Sat, 13 Dec 2003 23:41:53 -0500 (EST)
"Joe Stump" <joe@joestump.net> wrote:
> I would recommend making the existing Validate::creditCard() a wrapper
> for this.
Is there any case where you have to valid only the expiration date, the
cvv2, the number or the type? I can imagine to test the number for non
supported CC type, but...
I like the idea to enhance the CC validation, but failed to see the
needs of a whole new class (and file to parse). Any good reason to do it
so?
> cc_test.php doesn't conform to PEAR's coding standards. If this needs
> to be changed let me know.
PEAR CS has to be applied to every single file :). Tests cases must use
PHPUnit, see the existing simple tests scripts in head.
thanks for your work,
pierre