Re: ATTN: Validate Package Maintainer
| From: | Pierre-Alain Joye | Date: | Sun, 14 Dec 2003 14:35:22 +0000 |
| Subject: | Re: ATTN: Validate Package Maintainer | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-24414@lists.php.net to get a copy of this message | ||
On Sun, 14 Dec 2003 15:22:29 +0100
"Stefan Neufeind" <stefan@neufeind.net> wrote:
ut that.
>
> The new file (respective: class) is loaded the first time you use the
> function to Validate a IBAN in the Validate-package. Since this
> "quick check" already involves all possible checks for an IBAN I
> don't see a way to integrate a "leightweight"-functionality in
> Validate / Validate_Finance directly. If you don't use the IBAN-
> validation it won't be loaded. Where's the problem? How would you
> like to solve it? IMHO the current layout provides for best
> maintainance-ability and does loading of the additional IBAN.php-file
> only when needed.
I used IBAN implementation as an example. Even if that works well or
whatever, using the same way for a (maybe) widely used CC syntax
validation is not that good, imo. CC is basically the luhn algo. This
algo is used by many systems. That's why I like to have it in Validate
and not in a sub class. Again I'm talking _only_ about the syntax
validation of a CC and not about types, cvv2, dates, or other upcomings
things (like rpc methods).
By the way, I do not see a maintainance problem here.
> About CC-validation let's wait for Joe's replies.
About his plan, sure :). CC syntax is already in Validate (and will
certainly still be there in future release). I will fire the release
tonight.
pierre