Re: ATTN: Validate Package Maintainer
| From: | Stefan Neufeind | Date: | Sun, 14 Dec 2003 14:22:29 +0000 |
| Subject: | Re: ATTN: Validate Package Maintainer | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-24411@lists.php.net to get a copy of this message | ||
On 14 Dec 2003 at 13:23, Pierre-Alain Joye wrote:
> On Sun, 14 Dec 2003 12:58:18 +0100
> "Stefan Neufeind" <stefan@neufeind.net> wrote:
>
> > Yeah, that's what I also thought about. My intention was to do it
> > similar like with IBAN: In Validate itself (e.g. via multiple() )
> > you can quickly validate a CC. Also there is the same
> > quick-validatation possible via Validate/Finance.php. And as far as
> > I understood your mail now (haven't had a look at the source of the
> > creditcard-class yet!) there would be a
> > Validate/Finance/Creditcard.php which would be used if an app wants
> > to verify a CC with all details (e.g. for output "no, -this or that-
> > part is not valid" etc.
>
> > So Pierre, did I get you correctly now?
>
> Yes and no. The only thing I do not like in the IBAN approach is I
> have to load a new class (which loads another file) to get basic IBAN
> validation. Keeping the CC syntax validation in Validate:: skip the
> useless loads. Finance_CC should contain all "advanced" validation,
> and/or online/offline validations systems (ie validate again a
> webservice or a database) but I do not know the Joe's plans about
> that.
The new file (respective: class) is loaded the first time you use the
function to Validate a IBAN in the Validate-package. Since this
"quick check" already involves all possible checks for an IBAN I
don't see a way to integrate a "leightweight"-functionality in
Validate / Validate_Finance directly. If you don't use the IBAN-
validation it won't be loaded. Where's the problem? How would you
like to solve it? IMHO the current layout provides for best
maintainance-ability and does loading of the additional IBAN.php-file
only when needed.
About CC-validation let's wait for Joe's replies.
> > And finally: Who's gonna do it? I'm currently a bit too work-loaded
> > before christmas and intend to put the remaining time on work for
> > Image_Graph. So if Pierre could integrate CC-validation into Finance
> > that would be really nice. (Pierre, I know I proposed to take the
> > Finance-part ... but I can't find time to work on the CC-things
> > befroe 2004 otherwise.)
>
> Well, I can take care of its integration today, at least for the basic
> stuff and the 1st shot of Finance_CC. Note that this release will
> still be alpha. There are a few things I would like to add before the
> any beta releases (aka something like the single call described by
> Mike).
Okay. But at least having *any* new release (independent of state)
would be really nice :-)
Regards,
Stefan