Re: [PEPr] Comment on Date and Time::Date_Holidays
| From: | Philippe Jausions | Date: | Sun, 20 Jun 2004 17:31:27 +0000 |
| Subject: | Re: [PEPr] Comment on Date and Time::Date_Holidays | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-30965@lists.php.net to get a copy of this message | ||
Carsten Lucke wrote:
Philippe Jausions wrote: I would suggest to use the two-letter country code for the driver names. That will help for automated loading of holidays based on the Accept-Language HTTP header. Of course this is a good idea, but there will also be drivers (like Date_Holidays_Driver_UNO) for things that have no such code. So if I use country-codes for some drivers and real-life names for others the whole thing of naming drivers would be inconsistently.Hummm.. I think everybody could live with that ;-) Since country names have been standardized, why not using them for that purpose even at the cost of name inconsistency with exceptions. It's easier to extract a country code from a Locale and use it as is, then having to add an extra mapping to driver name... I guess the non-working holidays have to be handled by a customer driver, right? -Philippe