Re: Re: [PEPr] Comment on Date and Time::Date_Holidays
| From: | Stephan Schmidt | Date: | Sun, 20 Jun 2004 17:32:00 +0000 |
| Subject: | Re: Re: [PEPr] Comment on Date and Time::Date_Holidays | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-30966@lists.php.net to get a copy of this message | ||
Hi,
I would suggest to use the two-letter country code for the driver names. That will help for automated loading of holidays based on the Accept-Language HTTP header. What would you use for Christian or Jewish drivers? A lot of holidays are religious, so these classes are pretty important...Furthermore there are different states in Germany, that have different holidays, two letters will probably not be sufficient in these cases. However I have no hard feelings for mixing two letter codes with full names. Regarding the import, I guess this is no problem, can easily be implemented using a new driver: $d = &Date_Holidays::factory('INI', 2004, 'en_EN'); $d->importHolidaysFromIniFile('myHolidays.ini'); Shouldn't be too hard implementing this. Stephan