[PEPr] Comment on Networking::Net_SMPP

bertrand Gugger (http://pear.php.net/user/toggg) has commented on the proposal for Networking::Net_SMPP. Comment: I mean I don't see the interest of your static calls which will allways redo the same thing. More dangerous: the static hide the sharing of data thru globals. Your example of client is tricky about that: direct and via object "static" calls to finally access the same global structure. The includes chains are awfull. I've the feeling it's done to be "OO correct" but that result is worse as a "flat" script. I would encourage you to build a real class containing the config and abandon this false factory idea. Sorry, if my frankness hurts... it's more that I like to use such a package ! 2 more little things: * your directory structure is not right, check CS * don't use unpack() without giving the length of items: PHP4.2.2 is buggy in that case. Hope that serves. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=239 -- Sent by PEPr, the automatic proposal system at http://pear.php.net