[PEPr] Comment on Networking::Net_SMPP

bertrand Gugger (http://pear.php.net/user/toggg) has commented on the proposal for Networking::Net_SMPP. Comment: This comment is also concerning the client proposal. Constants name should be NET_SMPP_XXX (ESME_XXX in PDU.php) Could you present your Net_SMS implementation, as maintainer of it I did not get a copy and anyway a practical example of Net_SMPP's (and client) use would be meaningfull. The factories should do: $obj =& new $class(...); return $obj; instead of: return new $class(...); Btw, I've a strange feeling about a class containing its own static factory, but you're not alone to do that ... I tested out _unpack() on PHP4.2.2 , seems ok. Generally, I still not understand this over complicated structure, or if it's due, I would say it is quite difficult to check :), could you produce some schema/explanations ? How is the vendor set in Client ? Sorry, I'm missing something certainly. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=239 -- Sent by PEPr, the automatic proposal system at http://pear.php.net