Re: [PEPr] Comment on Networking::Net_SMPP

On Friday 10 June 2005 05:27 am, bertrand Gugger wrote: > bertrand Gugger (http://pear.php.net/user/toggg) has commented on the > proposal for Networking::Net_SMPP. > > Comment: > > This comment is also concerning the client proposal. > Constants name should be NET_SMPP_XXX (ESME_XXX in PDU.php) > Fixed in my CVS. I'll upload new packages after any other concerns get addressed. > Could you present your Net_SMS implementation, as maintainer of it I did > not get a copy and anyway a practical example of Net_SMPP's (and client) > use would be meaningfull. > Attached. I mailed this to the Net_SMS leads. They weren't too happy that my code needed a patch to work; I explained why, and never got anything back. So, Net_SMS devs, what do I need to change for you to accept this? > The factories should do: $obj =& new $class(...); return $obj; > instead of: return new $class(...); > Is there a reason for this? Does 'return new...' copy instead of return a reference? > I tested out _unpack() on PHP4.2.2 , seems ok. > Generally, I still not understand this over complicated structure, or if > it's due, I would say it is quite difficult to check :), could you produce > some schema/explanations ? > The structure of _unpack(), or of the package(s) as a whole? > How is the vendor set in Client ? > $smsc =& new Net_SMPP_Client('smsc.provider.com', 3204); $smsc->vendor = 'myVendor'; $smsc->connect();

Attachment: [application/x-php] generic_smpp.php
Attachment: [text/x-diff] Net_SMS-params.diff
Attachment: [application/pgp-signature]